I’m sure there are many ways to improve on this solution, but they would all require significantly more effort (ElasticSearch isn’t exactly trivial to set up).
This is really just a proof of concept, the most minimal viable implementation that gets you something similar in terms of functionality.
For instance, Windows Recall stores OCR content tagged by app, this solution doesn’t. Also, as others have mentioned, a practical implementation should likely check if anything has changed at all and discard any screenshots that don’t have any new data.
For regular PCs or laptops, which generally have at most one of each type of adapter, I don’t see any reason not to.